On Wed, 22 Apr 2015 01:42:39 +0200 Michael Niedermayer <michae...@gmx.at> wrote:
> On Wed, Apr 22, 2015 at 01:09:26AM +0200, wm4 wrote: > > On Wed, 22 Apr 2015 00:48:30 +0200 > > Michael Niedermayer <michae...@gmx.at> wrote: > > > > > On Tue, Apr 21, 2015 at 09:33:51PM +0200, wm4 wrote: > > > > --- > > > > Feel free to squash with the previous patch if it's too fine-grained. > > > > --- > > > > libavformat/mp3dec.c | 7 ++----- > > > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > > > this breaks fate-seek-acodec-mp2 > > > > > > [...] > > > > The old behavior is quite inconsistent: > > > > - if the file has a LAME header > > - the start of the file skps at least 529 samples > > - seeking to the start also does > > - if the file has no LAME hesder > > - the start of the file skips no samples > > - seeking to the start skips 529 samples > > > > So should it skip data on the start or not? (If no LAME header.) > > hmm, i was not conciously aware of it being inconsistent > > iam not against the change the patch does if you think its ok and > the patch that introduces it also updates the fate checksum > > [...] I chose not to skip samples at all if the LAME header is missing. Patches resent. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
