On Thu, Aug 5, 2021 at 2:22 AM Nicolas George <geo...@nsup.org> wrote:
> Linjie Fu (12021-08-05):
> > > > - if (scale->flags_str) {
> > > > + if (*scale->flags_str) {
> > > It could still be NULL, IIRC.
> > sws_flags doesn't have a candidate for "" (NULL) [1].
> > Hence NULL input for flags leads to a parsing issue:
>
> It is not what I am talking about.
>
> The application can set scale->flags to NULL. If it does,
> *scale->flags_str crashes.
>
Got your point, change it locally into:
- if (scale->flags_str) {
+ if (scale->flags_str && *scale->flags_str) {
Thanks for the review. Plan to apply soon if no more comments.
- linjie
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
