On Mon, Apr 20, 2015 at 02:37:27PM +0200, Ludmila Glinskih wrote: > ffmpeg | branch: master | Ludmila Glinskih <lglins...@gmail.com> | Mon Apr 20 > 03:03:08 2015 +0300| [be70c79af2bbbf8818707075ebc376d0be137582] | committer: > Michael Niedermayer > > libavcodec: Add FLAC API test > > Signed-off-by: Ludmila Glinskih <lglins...@gmail.com> > Signed-off-by: Michael Niedermayer <michae...@gmx.at> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=be70c79af2bbbf8818707075ebc376d0be137582 > --- > > libavcodec/Makefile | 1 + > libavcodec/api-flac-test.c | 290 > ++++++++++++++++++++++++++++++++++++++++++++ > tests/fate/libavcodec.mak | 6 + > 3 files changed, 297 insertions(+) > [...]
> +TESTPROGS += api-flac
Mmh... no TESTPROGRES-$(CONFIG_FLAC_DECODER) or similar?
[...]
> + if (!ctx)
> + {
Sorry to comment on such superficial issue, but this style (repeated all
over the file) is an obvious violation of the coding style of the project.
If the author or the person pushing the patch could fix this, that would
be appreciated.
Thanks
[...]
--
Clément B.
pgpjeSe2cjV5E.pgp
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
