Am 20.07.21 um 10:28 schrieb Andreas Rheinhardt:
> Thilo Borgmann:
>> Am 20.07.21 um 00:27 schrieb Andreas Rheinhardt:
>>> Thilo Borgmann:
>>>> Am 19.07.21 um 23:51 schrieb James Almer:
>>>>> On 7/19/2021 6:47 PM, Thilo Borgmann wrote:
>>>>>> Am 19.07.21 um 23:20 schrieb James Almer:
>>>>>>> On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote:
>>>>>>>> Thilo Borgmann:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> $subject for the new force cpu count function.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Thilo
>>>>>>>>>
>>>>>>>>
>>>>>>>> I just wanted to complain that you did not modify APIchanges as well;
>>>>>>>> but then I noticed that there is no entry there for this new function.
>>>>>>>> But there should be.
>>>>>>>
>>>>>>> No version bump either, so this patch should definitely do both things.
>>>>>>
>>>>>> Ok, does the attached look better?
>>>>>
>>>>> You need to bump the library version when you add new API. Since you
>>>>> didn't when you first added the function, you can do it now.
>>>>> And of course, the version you report in doc/APIchanges should be the one
>>>>> that introduced the new API.
>>>>
>>>> Hopefully compliant patch attached.
>>>
>>>
>>>
>>>> -void av_force_cpu_count(int count){
>>>> +void av_cpu_force_count(int count){
>>>> atomic_store_explicit(&cpu_count, count, memory_order_relaxed);
>>>> }
>>>
>>> While just at it, you can put the '{' on a line of its own as we do for
>>> opening brackets of functions.
>>
>> Attached.
>>
> No objection from me for this version.
Pushed. Thank you!
-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
