Thilo Borgmann:
> Hi,
>
> seems like someone at Apple thought its a good idea to allow this inside the
> framework....
>
>
>
> + if (block_buffer_size > ctx->audio_buffer_size) {
> + ctx->audio_buffer_size = block_buffer_size;
> + ctx->audio_buffer = av_realloc(ctx->audio_buffer,
> block_buffer_size);
> + if (!ctx->audio_buffer) {
> + av_log(s, AV_LOG_ERROR, "error allocating audio
> buffer\n");
> + return 1;
> + }
> }
Leak on error; furthermore setting the new size before it has been
successfully allocated is probably not good.
(Not commenting on the rest of the patch.)
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
