On Fri, 2015-04-10 at 20:02 -0700, Mark Reid wrote: > @@ -2055,8 +2083,35 @@ static int mxf_write_header(AVFormatContext *s) > av_log(s, AV_LOG_ERROR, "MXF D-10 only support 16 or 24 > bits le audio\n"); > } > sc->index = > ((MXFStreamContext*)s->streams[0]->priv_data)->index + 1; > - } else > - mxf->slice_count = 1; > + } else if (s->oformat == &ff_mxf_opatom_muxer) { > + AVRational tbc = av_inv_q(mxf->audio_edit_rate); > + > + if (st->codec->codec_id != AV_CODEC_ID_PCM_S16LE && > + st->codec->codec_id != AV_CODEC_ID_PCM_S24LE) { > + av_log(s, AV_LOG_ERROR, "MXF OPAtom only supports 16 or > 24 bits le audio\n");
This should perhaps be reworded as "Only 16- and 24-bit LE is implemented" since the spec itself allows loads more. > + return AVERROR(EINVAL); > + } > + if (st->codec->channels != 1) { > + av_log(s, AV_LOG_ERROR, "MXF OPAtom only supports single > channel audio\n"); Similar here. Looks OK otherwise. /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel