The test program for the FIFO muxer allocates a buffer without padding
and wraps it into a packet via av_packet_from_data(). This is an API
violation. Furthermore, said buffer leaks in case av_packet_from_data()
fails. Fix both of these issues by using av_new_packet() instead.
Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com>
---
libavformat/tests/fifo_muxer.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/libavformat/tests/fifo_muxer.c b/libavformat/tests/fifo_muxer.c
index e8970259c4..227c3d0210 100644
--- a/libavformat/tests/fifo_muxer.c
+++ b/libavformat/tests/fifo_muxer.c
@@ -41,18 +41,15 @@ typedef struct FailingMuxerPacketData {
static int prepare_packet(AVPacket *pkt, const FailingMuxerPacketData
*pkt_data, int64_t pts)
{
- int ret;
- FailingMuxerPacketData *data = av_malloc(sizeof(*data));
- if (!data) {
- return AVERROR(ENOMEM);
- }
- memcpy(data, pkt_data, sizeof(FailingMuxerPacketData));
- ret = av_packet_from_data(pkt, (uint8_t*) data, sizeof(*data));
+ int ret = av_new_packet(pkt, sizeof(*pkt_data));
+ if (ret < 0)
+ return ret;
+ memcpy(pkt->data, pkt_data, sizeof(*pkt_data));
pkt->pts = pkt->dts = pts;
pkt->duration = 1;
- return ret;
+ return 0;
}
static int initialize_fifo_tst_muxer_chain(AVFormatContext **oc, AVPacket
**pkt)
--
2.27.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
