Thank you Hendrik for your feedback. Let me look into it addressing it. Thank you Suji
On Thu, Mar 4, 2021 at 12:11 AM Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Thu, Mar 4, 2021 at 7:20 AM <suji.velupil...@broadcom.com> wrote: > > > > From: Patrick Rault <patrick.ra...@broadcom.com> > > > > Add support to allow attached hardware to add/remove reference to the > > frame buffer mirroring the ffmpeg. > > > > Signed-off-by: Patrick Rault <patrick.ra...@broadcom.com> > > Signed-off-by: Suji Velupillai <suji.velupil...@broadcom.com> > > New API additions should include an explanation of which problems this > solves, how it should be used, and why it is necessary. Otherwise we > have no reference to even judge the usefulness of such an API. > > Looking at the patch, the change to av_frame_ref looks fishy to me. > Why would dst reference itself, and not src? > > - Hendrik > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
