> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Nicolas > George > Sent: 2021年3月4日 16:58 > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref > private_ref when frame leaves libavfilter > > Guo, Yejun (12021-03-04): > > For option 1.1, it is not allowed because .h file (structs for > > bounding box) for side data is not exported. > > > > For option 1.2, to avoid the possible risk of API breaking, we need a > > versioning management, and the code such as BoundingBoxV1 and > > BoundingBoxV2 etc. is not elegant. > > Have you considered option 1.3: > > 1.3. Add the enum for a new side data, but document: > > /** > * The data is for internal use by libavfilter. > */ > > For the users, it is equivalent to storing it in private_ref, since it is > private, but it > is closer to the good long-term API where the information is eventually > available outside. >
Thanks a lot, I think this is the best option, will follow this if there is no objection. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
