To clarify this patch, a key component in the new fateserver is the support
for the separation of release branches from the master branch. This depends
on adding the branch information to the FATE payload headers. Libav has
already made the change to both fateserver and fate.sh a while ago, but
unfortunately their fateserver source code is not open to public (even
though Måns has released it under ISC license). Therefore when merging the
code to fate.sh Michael commented it out.

This patch does not represent that fate.ffmpeg.org will have full branches
support, but rather that version 1 (the version with branch info) headers
will be parsed correctly.

I will send a patch to enable the use of version 1 headers in fate.sh after
this is applied.

On an unrelated note, the design for version 1 is pretty dumb, as one can
simply make `branch` the last element to avoid API break.

On Tue, Apr 7, 2015 at 7:45 PM Timothy Gu <timothyg...@gmail.com> wrote:

> diff --git a/FATE.pm b/FATE.pm
> index 544e80f..30c220b 100644
> --- a/FATE.pm
> +++ b/FATE.pm
> @@ -47,7 +47,7 @@ our $gitweb = "http://git.videolan.org/?p=ffmpeg.git";;
>  sub split_header {
>      my @hdr = split /:/, $_[0];
>      $hdr[0] eq 'fate' or return undef;
> -    return {
> +    my $parsed = {
>          version => $hdr[1],
>          date    => $hdr[2],
>          slot    => $hdr[3],
> @@ -56,6 +56,11 @@ sub split_header {
>          errstr  => $hdr[6],
>          comment => $hdr[7],
>      };
>


> +    if ($hdr[1] eq '1') {
> +      $parsed->{'comment'} = $hdr[8];
> +      $parsed->{'branch'}  = $hdr[7];
> +    }
>

Perl guru needed to maybe shorten this.


> +    return $parsed;
>  }
>
>  sub split_config {
>

Timothy
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to