On Wed, Feb 24, 2021 at 9:51 PM Nicolas George <geo...@nsup.org> wrote: > I never told you to duplicate code. Code duplication is almost always a > motive for rejection. > > If you are tempted to duplicate code, what you need to do is to share it > between the various places that use it. Making it a proper API if > relevant.
I didn't really duplicate anything; this was mostly from scratch. The case could be made that a function for escaping CSV could be shared. There are at least two such functions already in the code base. > Ideally, all the writers of ffprobe should be turned into a single > libavutil API for use in all components that need to output data. That'd make sense. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
