These made sense before 3ebf449766d4b69a7774c4990fb24fe71c848a3e
when the creation of these boxes was specifically requested by the
user, but now they have become unnecessary as they are just like
many other boxes: If the input has the information required, they
are written, otherwise they are not.
They were moved to verbose verbosity level (which happens to be
the last level still relatively usable), and now appear either once
(normal MP4 muxing), or thrice (with the faststart flag set) in
any normal MP4 usage, without giving much useful information. Thus,
remove them in their current form.
---
For the record, I am not against having f.ex. the mdcv box writing function
warning in case the side data is there, but it lacks the required information.
But just always logging this stuff, even if the user didn't go anywhere near
streams with such information does not feel like something useful at this
level of verbosity (esp. with the faststart flag causing it to appear thrice).
Jan
---
libavformat/movenc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 372c04295d..62192e5c24 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -2025,7 +2025,6 @@ static int mov_write_clli_tag(AVIOContext *pb, MOVTrack
*track)
side_data = av_stream_get_side_data(track->st,
AV_PKT_DATA_CONTENT_LIGHT_LEVEL, NULL);
if (!side_data) {
- av_log(NULL, AV_LOG_VERBOSE, "Not writing 'clli' atom. No content
light level info.\n");
return 0;
}
content_light_metadata = (const AVContentLightMetadata*)side_data;
@@ -2052,7 +2051,6 @@ static int mov_write_mdcv_tag(AVIOContext *pb, MOVTrack
*track)
side_data = av_stream_get_side_data(track->st,
AV_PKT_DATA_MASTERING_DISPLAY_METADATA, NULL);
metadata = (const AVMasteringDisplayMetadata*)side_data;
if (!metadata || !metadata->has_primaries || !metadata->has_luminance) {
- av_log(NULL, AV_LOG_VERBOSE, "Not writing 'mdcv' atom. Missing
mastering metadata.\n");
return 0;
}
--
2.29.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
