On Mon, Jan 25, 2021 at 2:50 PM Nicolas George <geo...@nsup.org> wrote: > > Jan Ekström (12021-01-25): > > I knew that would be useful, but opted out of it since: > > 1. For now I didn't yet need it. > > That is not a good reason. > > > 2. I wanted to keep out of the actual playlist parsing code. > > I know, file parsing code is not nice. But this is what needs doing. > > > 3. Possible security ramifications (since we already have "safe" / > > "unsafe" playlist entries). > > You are right, we need to treat options as unsave. > > > > > It is a relatively simple extension yes, if you ignore the points 2/3. > > You have an AVDictionary per file and after initializing the > > AVDictionary in the opening function and applying global input options > > - copy the contents of the per-file options there, too. > > Please, no half-baked solution. >
I am pretty sure you mis-understood what I meant here. I meant that if you exclude those bits that I was not interested in (namely, parsing the playlist file and handling the "safe" flag), the extension would be simple. Not meaning half-baked solutions. Pushed a version last night which seems to now include the parsing changes to a branch: https://github.com/jeeb/ffmpeg/commits/add_input_options_to_concatdec If this looks good, I'll just update the documentation and post it on the mailing list. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
