Re: [FFmpeg-devel] [PATCH v3 1/2] vc2enc: Add missing static to local variables

[Mark Thompson]

On 28/01/2021 19:16, Michael Niedermayer wrote:

On Mon, Jan 25, 2021 at 10:07:01PM +0000, Mark Thompson wrote:

---
  libavcodec/vc2enc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c
index bab9d0f3d5..7bd2e4c2ab 100644
--- a/libavcodec/vc2enc.c
+++ b/libavcodec/vc2enc.c
@@ -423,7 +423,7 @@ static void encode_slice_params(VC2EncContext *s)
  }

/* 1st idx = LL, second - vertical, third - horizontal, fourth - total */

-const uint8_t vc2_qm_col_tab[][4] = {
+static const uint8_t vc2_qm_col_tab[][4] = {
      {20,  9, 15,  4},
      { 0,  6,  6,  4},
      { 0,  3,  3,  5},
@@ -431,7 +431,7 @@ const uint8_t vc2_qm_col_tab[][4] = {
      { 0, 11, 10, 11}
  };

-const uint8_t vc2_qm_flat_tab[][4] = {

+static const uint8_t vc2_qm_flat_tab[][4] = {
      { 0,  0,  0,  0},
      { 0,  0,  0,  0},
      { 0,  0,  0,  0},

LGTM

Pushed.

Thanks,

- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".