On Sun, Jan 31, 2021 at 12:29 PM Marton Balint <c...@passwd.hu> wrote:
>
>
> On Sun, 31 Jan 2021, Paul B Mahol wrote:
>
> > On Sun, Jan 31, 2021 at 12:00 PM Marton Balint <c...@passwd.hu> wrote:
> >
> >>
> >>
> >> On Tue, 26 Jan 2021, Paul B Mahol wrote:
> >>
> >> > This work is sponsored by Open Broadcast Systems.
> >> >
> >> > Signed-off-by: Paul B Mahol <one...@gmail.com>
> >> > ---
> >> > configure | 5 +
> >> > doc/protocols.texi | 32 +++++
> >> > libavformat/Makefile | 1 +
> >> > libavformat/librist.c | 251 ++++++++++++++++++++++++++++++++++++++++
> >> > libavformat/protocols.c | 1 +
> >> > 5 files changed, 290 insertions(+)
> >> > create mode 100644 libavformat/librist.c
> >>
> >>
> >> [...]
> >>
> >>
> >> > --- a/doc/protocols.texi
> >> > +++ b/doc/protocols.texi
> >> > @@ -690,6 +690,38 @@ Example usage:
> >> > -f rtp_mpegts -fec prompeg=l=8:d=4 rtp://@var{hostname}:@var{port}
> >> > @end example
> >> >
> >> > +@section rist
> >> > +
> >> > +Reliable Internet Streaming Transport protocol
> >> > +
> >> > +The accepted options are:
> >> > +@table @option
> >> > +@item rist_profile
> >> > +Supported values:
> >> > +@table @samp
> >> > +@item simple
> >> > +@item main
> >> > +This one is default.
> >> > +@item advanced
> >> > +@end table
> >> > +
> >> > +@item buffer_size
> >> > +Set internal RIST buffer size for retransmission of data.
> >> > +
> >> > +@item pkt_size
> >> > +Set internal RIST buffer size for receiving and sending data.
> >>
> >> You should mention the default here. And by the way, why have you
> selected
> >> 9968 as default? I thought primaryly mpegts is targeted, so maybe 1316
> >> makes more sense no?
> >>
> >>
> > NO
>
> Please explain why, and give a reason for 9968 then.
>
because that is max allowed value that works, I really wonder why it should
be lowered.
>
> >> > + if (s->secret && peer_config->secret[0] == 0)
> >> > + av_strlcpy(peer_config->secret, s->secret,
> >> FFMIN(RIST_MAX_STRING_SHORT - 1, strlen(s->secret)));
> >>
> >> Simply av_strlcpy(peer_config->secret, s->secret,
> RIST_MAX_STRING_SHORT).
> >>
> >
> > Really? Are you sure?
>
> It looks to me that is exactly what is needed here.
>
ok
> Thanks,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
