Jonathan Baudanza:
> On Sun, Jan 3, 2021, at 3:34 PM, Andreas Rheinhardt wrote:
>> Lynne:
>>>
>>> Apart from that LGTM.
>>
>> +1 if the case of more than two channels has been properly tested.
>>
> 
> I tested this by creating an (invalid) SDP file with channels set to 3. In 
> this case, the rtp demuxer fails with the following message:
> 
>    [sdp @ 0x7fe40280b800] Error creating opus extradata: Invalid data found 
> when processing input
> 
> It might be more descriptive if we added a log warning about the channel 
> count. WDYT?

It's ok as-is.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to