On Tue, Dec 8, 2020 at 9:44 PM James Almer <jamr...@gmail.com> wrote: > > Signed-off-by: James Almer <jamr...@gmail.com> > --- > libavcodec/h264_sei.c | 31 ++++++++++++++++++++++--------- > 1 file changed, 22 insertions(+), 9 deletions(-)
Set generally OK, just some minor things: - probably AVERROR(EINVAL) usage should be AVERROR_INVALIDDATA ? - Unrelated to this specific set (but just visible in the context of the change), but I see that we seem to have generally not handled the case of country_code == 0xFF && size == 7 (or 3). I think while we're refactoring this code we could just add a "if (size < 1) return AVERROR_INVALIDDATA;" into that country_code == 0xFF check? Should make it handle that specific case now. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
