James Almer: > On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: >> This option just creates broken output because an MPEG-1 bitstream >> can't signal whether MPEG-2 intra VLC tables have been used. >> >> Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com> >> --- >> Missing version bump. >> >> doc/APIchanges | 3 +++ >> libavcodec/mpeg12enc.c | 7 +++++-- >> 2 files changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/doc/APIchanges b/doc/APIchanges >> index b70c78a483..dea54c4415 100644 >> --- a/doc/APIchanges >> +++ b/doc/APIchanges >> @@ -15,6 +15,9 @@ libavutil: 2017-10-21 >> API changes, most recent first: >> +2020-xx-xx - xxxxxxxxxx - lavc 58.xx.100 - avcodec.h >> + Deprecate the "intra_vlc" option for the mpeg1video encoder. > > Options usually don't get APIChanges entries, either when they are added > or removed. > I saw this: > 2018-02-04 - ff46124b0d - lavf 58.8.100 - avformat.h > Deprecate the current names of the RTSP "timeout", "stimeout", "user-agent" > options. Introduce "listen_timeout" as replacement for the current "timeout" > option, and "user_agent" as replacement for "user-agent". Once the > deprecation > is over, the old "timeout" option will be removed, and "stimeout" will be > renamed to "stimeout" (the "timeout" option will essentially change > semantics).
and therefore concluded that adding an APIChanges entry is appropriate; but I can of course also omit it. Is a version bump necessary? If yes, minor or micro? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
