On Fri, Nov 6, 2020 at 11:46 AM Steven Liu <l...@chinaffmpeg.org> wrote: > > > > > 2020年11月6日 下午4:42，Bohan Li <boha...@google.com> 写道： > > > > Thanks for the reply, Steven! > > > > Regarding JEEB’s comment, the suggestion was to add an api to the *libaom* > > library, not to ffmpeg. I do agree with the rationale, but when such an api > > would be available for ffmpeg to use is quite uncertain. In the meanwhile, > > I believe it is reasonable to add in this patch to expose the option to the > > users. I don’t think this is a “middle version”, since as mentioned, this > > option could be quite useful in certain scenarios and IMHO should be added > > in. > What about use av1_param arguments? As x264opts, x265opts?
The problem with this is that libaom as far as I can tell doesn't have an API like that. Thus each and every API user that needs to have options defined as strings will have to *duplicate* those mappings (which already are defined in the aomenc command line application, but not exposed through the API). This has been the butt of jokes and reason for lamentations on IRC for quite a while, but unfortunately nobody actually seems to have voiced an opinion on this on the mailing list until now? Thus there generally speaking are only two ways forward for this: 1. This is really spammy and unfortunate (and getting these removed will be a PITA after we actually do get a key & value based API), but we take the additional option in. 2. This is apparently a low usage option and the amount of AVOptions in this encoder is getting higher and higher, thus we deny the patch until a key, value based API is provided. Personally I lean somewhat towards 2, but if the option is needed/useful (use cases can be provided), then begrudgingly I could go for 1. So far the lack of comments has mostly been regarding people not having high enough stakes/care regarding this module, methinks? Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
