On Thu, Oct 29, 2020 at 04:22:23PM +0100, Andreas Rheinhardt wrote: > Nicolas George: > > Michael Niedermayer (12020-10-28): > >> Fixes: out array read > >> Fixes: > >> 26610/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-5631838049271808 > >> > >> Found-by: continuous fuzzing process > >> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > >> Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > >> --- > >> libavformat/concatdec.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > > > This is not the first time such a fix is proposed. If strcmp() does not > > behave intelligently, then we need an extra function for the task, but > > duplicating the test all over the place is not a good idea. > > > We already have av_strstart() which would also allow us to avoid > computing strlen(proto) at all.
patch with av_strstart() posted, av_strstart() was available since a long time so it should have no negative impact on backporting thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
