On Wed, Oct 28, 2020 at 4:58 PM Jan Ekström <jee...@gmail.com> wrote: > > On Tue, Oct 27, 2020 at 8:30 PM Jan Ekström <jee...@gmail.com> wrote: > > > > This patch set started with a very simple wish to not have to set color > > related values manually each time when utilizing ffmpeg.c. > > > > As of the fourth iteration, the following changes were done since the third: > > 1. The data size threshold patch was moved to be the first one, thus meaning > > that there is no case of it not being applied, and the encoder > > initialization > > being moved later. > > 2. As noted by Anton, as the encoder options are applied after the > > AVFrame-based configuration, that code can be simplified to just > > simple passing of values instead of first checking if the option is > > set in the dictionary. > > 3. Interlaced/progressive and field order decision making commit has been > > reworded to include an explanation of the FATE test changes. > > > > Unfortunately, audio still needs two locations where the encoder is > > initialized, due to how avfilter_graph_request_oldest peeks and already puts > > one AVFrame to be available from the filter graph (which is then utilized > > as-is as an early return inside both av_buffersink_get_frame_flags and > > av_buffersink_get_samples). If this would be improved in lavfi (or the call > > to avfilter_graph_request_oldest removed), we could at least remove one of > > these. > > > > Currently limited to using values for video and started with the basic > > values, > > more can be added later if needed. > > > > This probably fixes some trac issues, but with a quick look I couldn't find > > anything that explicitly was due to lack of video color metadata > > passthrough. > > > > Received an approval from Anton, so unless there are objections I will > be pulling this set in tomorrow evening. >
Applied patch set as: 453b2f3c154f6b83221940ad411599ded91f7413 3360c9a5679cc9bd83ab5860757ebab8f64ea8ba 67be1ce0c6de330b1c10d1d121819d8a74a7b1f5 7369595c556516b90bf3acdf85043dc11add7d89 fbb44bc51a647862eb05ae3f9d7d49a0be9bed57 Thanks for testing and reviews to everyone who participated, especially Michael and Anton. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
