Hendrik Leppkes:
> On Fri, Sep 18, 2020 at 8:25 AM Andreas Rheinhardt
> <andreas.rheinha...@gmail.com> wrote:
>>
>> This reverts commit 61669b7c40b8dc3a0841768fb39c7567513b7cfc.
>>
>> This commit broke building with MSVC due to its spec-incompliant handling
>> of ',' in __VA_ARGS__: These are not treated as argument separators for
>> further macros, so that in our case the init_vlc2() macro is treated as
>> having only one argument whenever the init_vlc() macro is used. See [1]
>> for further details.
>>
>> [1]: https://reviews.llvm.org/D69626
>>
> 
> The new preprocessor mentioned in the llvm report is now officially
> available in VS2019 (ie. no longer experimental), but its opt-in to
> not break old code, and of course we want to support older versions as
> well for the time being, so reverting this is probably the only
> realistic option.
> 
> LGTM.
> 
> - Hendrik

Thanks, applied.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to