On Sat, 2015-03-21 at 16:45 -0700, Mark Reid wrote: > --- > libavformat/mxfenc.c | 100 > ++++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 83 insertions(+), 17 deletions(-)
Looks fine as far as I can tell. My only nitpick is that it might be better to call "timecode rate" EditRate or "edit rate" instead, since that is MXF parlance. Perhaps a bit bikeshed-y though. Does anyone else have any preference? An aside: would it ever make sense to use EditRate different from fps, to force a certain rate? Something tells me there's a video filter or something to do that already, so perhaps not an issue. /Tomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
