On Sun, 23 Aug 2020, Moritz Barsnick wrote:
Hej igen,
On Fri, Aug 21, 2020 at 12:19:06 +0300, Martin Storsjö wrote:
LGTM, with one small nit:
[...]
{"listen", "Listen for incoming connections", offsetof(pstruct,
options_field . listen), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, .flags = TLS_OPTFL }, \
+ {"http_proxy", "set proxy to tunnel through when using HTTPS",
offsetof(pstruct, options_field . http_proxy), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL }, \
{"verifyhost", "Verify against a specific hostname", offsetof(pstruct,
options_field . host), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL }
I'd remove the "when using HTTPS" bit here.
Done. I also chose to make the capitalization consistent, and move the
option down, as "verifyhost" is related to the certificate options (and
should thus perhaps even be above "listen").
Thanks, this version LGTM.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
