On 8/23/2020 8:36 AM, Mark Thompson wrote: > On 23/08/2020 03:02, James Almer wrote: >> Same logic as tile_cols and tile_rows, this saves CBS users having to >> recalculate these values, and makes them available for all frames >> within a >> Temporal Unit. >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> Not a fan of adding more derived values to "raw" structs, but much >> like the >> tile ones, these will be useful. > > Perhaps it would be cleaner to avoid adding anything by inferring values > for the existing frame_width_minus_1 / etc. fields in the cases where > they aren't directly in the bitstream? (In the same way the tile ones do.)
I suppose that if frame_size_override_flag is left as 0, inferring such values into frame_width_minus_1 will not result in them being written to the output. But what about upscaled_width and frame_width? We can only keep one in frame_width_minus_1. > >> libavcodec/cbs_av1.h | 8 +++++++ >> libavcodec/cbs_av1_syntax_template.c | 32 ++++++++++++++-------------- >> 2 files changed, 24 insertions(+), 16 deletions(-) >> >> ... > - Mark > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
