Paul B Mahol: > Make sure this does not break existing files, > I tested with all the samples in https://samples.ffmpeg.org/TiVo/; of course, there was no change in output at all. So I'll apply this.
- Andreas > On 8/11/20, Andreas Rheinhardt <andreas.rheinha...@gmail.com> wrote: >> Up until now, the TiVo demuxer parse an array of SEQ entries, yet it has >> never ever made any use of them. In fact, parse_master, the function >> parsing said table, only influenced the outside world in three ways: Via >> an excessive amount of error message in case a certain parameter is not >> what it expected; via an allocation (the aforementioned write-only >> array); and by setting a certain parameter (ty->cur_chunk_pos), but that >> parameter is always overwritten before it is used (it is overwritten >> in get_chunk() on success and if get_chunk() fails, the error is >> returned to the caller anyway). So remove the array and the function >> used to parse it. >> >> Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com> >> --- >> Furthermore, the parsing code seems not to work at all: The current >> position is not incremented by map_size if map_size <= 8. >> >> libavformat/ty.c | 68 +----------------------------------------------- >> 1 file changed, 1 insertion(+), 67 deletions(-) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
