On Sat, Mar 14, 2015 at 08:35:29PM -0300, James Almer wrote: > On 14/03/15 3:18 PM, Michael Niedermayer wrote: > > On Sat, Mar 14, 2015 at 03:30:27PM +0000, Christophe Gisquet wrote: > >> The later may yield incorrect code for on-stack variables. > >> --- > >> libavcodec/ppc/h264dsp.c | 10 ++++----- > >> libavcodec/ppc/h264qpel.c | 50 > >> ++++++++++++++++++++--------------------- > >> libavcodec/ppc/vp8dsp_altivec.c | 2 +- > >> 3 files changed, 31 insertions(+), 31 deletions(-) > > > > applied > > > > thanks > > This apparently broke compilation for ppc. > http://fate.ffmpeg.org/report.cgi?time=20150314231437&slot=powerpc-linux-gnu-gcc-4.3.5 > > /home/fate/fate/slots/powerpc-linux-gnu-gcc-4.3.5/src/libavcodec/ppc/h264dsp.c:270: > error: invalid parameter combination for AltiVec intrinsic
argh, i tested this, but i had altivec disabled it seems > > It should use LOCAL_ALIGNED_16() rather than LOCAL_ALIGNED(16,...), which > shows that > whatever these LOCAL_ALIGNED_# macros do is needed, and the fifth patch in > this set > is not correct. LOCAL_ALIGNED_# does not work either, ill revert the patch thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
