On 7/18/20, Steinar H. Gunderson <steinar+ffm...@gunderson.no> wrote: > On Sat, Jul 18, 2020 at 12:53:18PM +0200, Paul B Mahol wrote: >> Nope, algorithm is just fine. You are interpreting results wrongly. > > If you are not willing to tell me what is wrong with my interpretation > (outside “you are using the wrong parameters, and I won't tell you what the > right parameters are”), this is a hard claim to make. > > In short, this patch has: > > - An unusually slow algorithm (sin, cos, atan, division; all per-pixel).
This is actually good. Performance is not affected at all. > - Poor output quality (strong aliasing, no subpixel precision). I fixed this. No thanks to your patch. > - No comments, hardly any commit message. No comments are needed for developers that know how to code. > > Thus, I believe it should not be merged. It is just your belief, no any proof given. > > /* Steinar */ > -- > Homepage: https://www.sesse.net/ > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
