On 6/30/20 11:16 AM, Siyuan Huang wrote: > > Soory for wrong commit messge > > Update to no file mode modify at version2 > > From efd83d91a9bd9a485bcda6799f5f681c203a7449 Mon Sep 17 00:00:00 2001 > From: Siyuan Huang <saber.hu...@samsung.com> > Date: Tue, 30 Jun 2020 13:44:01 +0800 > Subject: [PATCH] libavformat/dashenc.c:kill latency when ldash on v2 > > disable write tmp file to let it using chunk downloading at last segment > > Signed-off-by: Siyuan Huang <saber.hu...@samsung.com> > --- > libavformat/dashenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index dc3306a56a..ef6e3d29c6 100644 > --- a/libavformat/dashenc.c > +++ b/libavformat/dashenc.c > @@ -2232,6 +2232,8 @@ static int dash_write_packet(AVFormatContext *s, > AVPacket *pkt) > AVDictionary *opts = NULL; > const char *proto = avio_find_protocol_name(s->url); > int use_rename = proto && !strcmp(proto, "file"); > + if (c->ldash) > + use_rename = 0; I guess, rename was added for file protocol to handle some corner-cases related to concurrent file access. Hence it may not be safe to disable them internally. Instead, I propose a new option for disabling rename feature so that users know exactly what they are asking for. > if (os->segment_type == SEGMENT_TYPE_MP4) > write_styp(os->ctx->pb); > os->filename[0] = os->full_path[0] = os->temp_path[0] = '\0'; > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://urldefense.proofpoint.com/v2/url?u=https-3A__ffmpeg.org_mailman_listinfo_ffmpeg-2Ddevel&d=DwIGaQ&c=96ZbZZcaMF4w0F4jpN6LZg&r=xOoesbz-6ff1GPXp5Lg4jf1ZG99yp4a1qhxVn_YOwRU&m=GHkxeN_WIsYgq8XYQY4j0c4OsL-Sgjc5Tmhf5Xl2kuU&s=XRu2dw1vQat2TOD1pmN6ua82e_1eNpvBWuN1jPAL8OE&e= > > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
