On Sun, Jul 05, 2020 at 09:56:02PM +0000, Soft Works wrote: > ... A significant part of code reviews are code-style violations. This is > really not something where humans should need to spend time for when > reviewing a patch.
you are correct but that is also the easy part of reviews. Its not what makes reviews time consuming. Rather while reviewing for technical stuff one notices maybe a formating issue > Neither should it be required that Michael responds manually each time > by stating "breaks FATE". We already have fully automatic build and fate tests for submitted patches its done by patchwork which should send a private mail to the submitter of a patch affected. Still not every environment is the same, and it passing on the patchwork box doesnt mean it builds on my mingw or mips environments for example. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "I am not trying to be anyone's saviour, I'm trying to think about the future and not be sad" - Elon Musk
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
