On Thu, Jul 02, 2020 at 01:30:34AM +0000, Guo, Yejun wrote: > > > > -----Original Message----- > > From: Michael Niedermayer <mich...@niedermayer.cc> > > Sent: 2020年7月2日 7:45 > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>; > > Guo, Yejun <yejun....@intel.com> > > Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand > > index > > > > On Wed, Jun 17, 2020 at 03:23:34AM +0000, Guo, Yejun wrote: > > > > > > > > > > -----Original Message----- > > > > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of > > > > Carl Eugen Hoyos > > > > Sent: 2020年6月16日 18:57 > > > > To: FFmpeg development discussions and patches > > > > <ffmpeg-devel@ffmpeg.org> > > > > Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check > > > > operand index > > > > > > > > > > > > > > > > > Am 16.06.2020 um 10:18 schrieb Guo, Yejun <yejun....@intel.com>: > > > > > > > > > > I personally like to always add '{}' to avoid possible mistakes > > > > > when we change > > > > code in the future. Some coding styles also recommend this method. > > > > > > > > > > I checked at http://ffmpeg.org/developer.html#Coding-Rules and do > > > > > not find > > > > an explicit description. But I just remembered that someone also > > > > mentioned this some time ago. I'll change to this style in v2 if no > > > > support from others for my style. > > > > > > > > I support your style but it is only the file maintainer‘s decision. > > > > > > thanks, I'll keep the V1 patch and push soon. > > > > please also apply this to affected release branches > > done, pushed to branch 4.3 with dd273d359e45ab69398ac0dc41206d5f1a9371bf and > 5530748bfdf1a4d41d4c92e59f662c94e38a5f94, > no need to apply 4.2 and older.
thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".