On Mon, Jun 8, 2020 at 7:03 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Mon, Jun 08, 2020 at 04:56:04PM +0800, myp...@gmail.com wrote: > > On Tue, Apr 2, 2019 at 5:20 AM Michael Niedermayer > > <mich...@niedermayer.cc> wrote: > > > > > > On Sun, Mar 31, 2019 at 02:32:34AM +0100, David Holroyd wrote: > > > > Previously, prompeg_write() would only report to caller that bytes we > > > > written when a FEC packet was actually created. Not all RTP packets are > > > > expected to generate a FEC packet however, so this behavior was causing > > > > avio to retry writing the RTP packet, eventually forcing the FEC state > > > > machine to send a FEC packet erroneously (and so breaking out of the > > > > retry loop). > > > > > > > > This was resulting in incorrect FEC data being generated, and far too > > > > many FEC packets to be sent (~100% FEC overhead). > > > > --- > > > > libavformat/prompeg.c | 6 ++---- > > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > this patch doesnt seem to apply automatically with git am > > > > > > also no fate test changes, which indicates that this code is not tested. > > > I think it would be rather useful if there was a test that covers this, > > > otherwise any future change to thsÃs code could break it with the person > > > noticing > > > > > > thanks > > It's about issue http://trac.ffmpeg.org/ticket/7863, and I can confirm > > this fix is working (with wireshark), can we merge this patch first? I > > will add the FATE testcase. > > as the patch did not apply with git am, no it cannot be applied obviously > > thx Will refine & re-submite the patch, thx _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
