Am 08.06.20 um 20:21 schrieb Nicolas George:
> Thilo Borgmann (12020-06-08):
>> v2 due to Nicolas remarks. One device, several formats.
>
> I cannot comment on appleisms, but here are a few general remarks:
>
>> From 64b100d7b4cfe780c273d6e7d8b940a8427cfdc9 Mon Sep 17 00:00:00 2001
>> From: Thilo Borgmann <thilo.borgm...@mail.de>
>> Date: Mon, 8 Jun 2020 13:04:11 +0200
>> Subject: [PATCH] lavdevice: Add AudioToolbox output device.
>>
>> ---
>
>> configure | 3 +
>> libavdevice/Makefile | 1 +
>> libavdevice/alldevices.c | 1 +
>> libavdevice/audiotoolbox.m | 299 +++++++++++++++++++++++++++++++++++++
>
[...]
>
>> +static av_cold int at_write_header(AVFormatContext *s)
>> +{
>> + ATContext *ctx = (ATContext*)s->priv_data;
>
> The convention is the opposite: ctx for the AVFormatContext, s for the
> private context.
Hmm I never liked *s anyway, however a grep revealed _a lot_ of AVFormatContext
*s.
And I always did c&p it from somewhere else...
Anyway, I did "AVFormatContext *avctx" in v3, which seems to be another common
naming that fits in better IMHO.
All other remarks done in v3.
Thanks for review!
-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
