On Fri, Jun 05, 2020 at 07:10:08PM +0200, Marton Balint wrote: > > > On Fri, 5 Jun 2020, Nicolas George wrote: > > > lance.lmw...@gmail.com (12020-05-25): > > > From: Limin Wang <lance.lmw...@gmail.com> > > > > > > Signed-off-by: Limin Wang <lance.lmw...@gmail.com> > > > --- > > > doc/indevs.texi | 19 +++++++++++++++++-- > > > libavdevice/lavfi.c | 8 +++++--- > > > 2 files changed, 22 insertions(+), 5 deletions(-) > > > > Either we case about backwards compatibility, and you cannot change the > > type of the existing option at all, or we do not, and it is not > > necessary to add another option. > > I think it always depended on the fallout, we were never blindly strict > about this. > > > > > I move we do not care much about compatibility: the syntax was never > > documented, except "1" should work. Then accept "1" and any valid > > key-value string. > > I suggested the separate option for the options because otherwise you can't > do dumpgraph without options specified, so you cant make the code call > avfilter_dump_graph(graph, NULL). > > "1" as a special string might be OK until some deprecation period but not > for all eternity if the options string wants to be an options list and if it > must be parseable as an AVDictionary. That would be the same inconsistency > which we tried to avoid all over the codebase. E.g. this option looks like a > dictionary, except "1" is also accepted...
When I'm try to understand how to use the option, no document, so I had to study the code, it's string type, but no code to use it, so I think it's boolean type. I guess most of user will have the same feeling. So I prefer to Marton's suggestion with separate option. > > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
