On Mon, Mar 9, 2015 at 11:06 PM, Michael Niedermayer <michae...@gmx.at> wrote: > On Mon, Mar 09, 2015 at 06:38:18AM +0000, Rainer Hochecker wrote: >> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes: >> >> > >> > Any reason to believe this patch causes it? >> > Because I can't see how it would. >> > Maybe it's just a bug with DXVA and multithreading in the HEVC code? >> > Can you provide some more information like a stacktrace, possibly using a >> tool like DrMemory? >> >> I don't think the patch itself is the root cause of the issue, it just >> triggers it. get_format is called 4 times, something seems to get corrupted >> in opening our hw decoder. >> Do you have an explanation why it works with thread_safe_callbacks set to 1? >> > >> I am wondering if hevc misses the multithreading fix done for other codecs: >> http://ffmpeg.org/pipermail/ffmpeg-cvslog/2013-March/062620.html > > from a quick look yes, this appears missing > can someone who can reprodeuce this problem test if adding such code > would fix it ? if yes please send a patch
Just making the ff_thread_finish_setup call in hevc_frame_start conditional on !hwaccel should do what the other patches did. My code isn't setup to use this path, so someone that does should test it and send it. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
