On Fri, May 29, 2020 at 5:01 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Fri, May 29, 2020 at 12:33:01AM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan <gautamr...@gmail.com> > > > > I have attempted to write a JPEG2000 Parser. Have tested > > by generating a file containing 14 frames, as mentioned > > by Micheal. Have also tried testing with various packet > > sizes by setting -frame_size option. Need feedback on the > > code and on further testing. > > --- > > libavcodec/Makefile | 1 + > > libavcodec/jpeg2000_parser.c | 190 +++++++++++++++++++++++++++++++++++ > > libavcodec/parsers.c | 1 + > > 3 files changed, 192 insertions(+) > > create mode 100644 libavcodec/jpeg2000_parser.c > > can you add some test to fate for this ? > (doesnt need to be related to the tests you did, but can of course) > such a test would also make it easy for others to test the code on > less common hardware like big endian ... > This can also be very simple test if its not easy Small doubt, so the jpeg2000 stream to be parsed goes in the test-suite directory and the corresponding framecrc goes into the test/ref directory? Is my understanding right? > > > > > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > > index d0917a656f..1f7c91a91b 100644 > > --- a/libavcodec/Makefile > > +++ b/libavcodec/Makefile > > @@ -1073,6 +1073,7 @@ OBJS-$(CONFIG_H261_PARSER) += > > h261_parser.o > > OBJS-$(CONFIG_H263_PARSER) += h263_parser.o > > OBJS-$(CONFIG_H264_PARSER) += h264_parser.o h264_sei.o > > h264data.o > > OBJS-$(CONFIG_HEVC_PARSER) += hevc_parser.o hevc_data.o > > +OBJS-$(CONFIG_JPEG2000_PARSER) += jpeg2000_parser.o > > OBJS-$(CONFIG_MJPEG_PARSER) += mjpeg_parser.o > > OBJS-$(CONFIG_MLP_PARSER) += mlp_parse.o mlp_parser.o mlp.o > > OBJS-$(CONFIG_MPEG4VIDEO_PARSER) += mpeg4video_parser.o h263.o \ > > diff --git a/libavcodec/jpeg2000_parser.c b/libavcodec/jpeg2000_parser.c > > new file mode 100644 > > index 0000000000..c28b694219 > > > --- /dev/null > > +++ b/libavcodec/jpeg2000_parser.c > > @@ -0,0 +1,190 @@ > > +/* > > + * JPEG2000 parser > > > + * Copyright (c) 2000, 2001 Fabrice Bellard > > Thats ok if you used code from fabrice but you probably want to > add your name assuming you wrote the parser > > [...] > > thx > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > The smallest minority on earth is the individual. Those who deny > individual rights cannot claim to be defenders of minorities. - Ayn Rand > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
-- ------------- Gautam | _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
