On Fri, 29 May 2020 01:15:09 +0200
"Michael Niedermayer" <mich...@niedermayer.cc> wrote:
> > +static int kvag_write_trailer(AVFormatContext *s)
> > +{
> > + int64_t file_size, data_size;
> > +
> > + if (!(s->pb->seekable & AVIO_SEEKABLE_NORMAL)) {
> > + av_log(s, AV_LOG_WARNING,
> > + "Stream not seekable, unable to write data size. "
> > + "Output file will be broken\n");
> > + return 0;
> > + }
>
> this could be checked earlier, checking it earlier would avoid
> transcoding the whole file just to fail
> or is such a broken file usefull in some usecase ?
No, there's no case in which a broken file is valid. I was just
following what wav_write_trailer() did in this case.
I'll put the check in kvag_write_init() and bail early.
Zane
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
