On Tue, May 19, 2020 at 05:02:42PM +0200, Nicolas George wrote: > Nicolas George (12020-05-19): > > Originally, the second parameter to avfilter_graph_dump() was supposed > > to be dump options. None was ever added, and I later came to realize > > that using a string for that was more of the same bad idea. > > > > I have no objection to making this bit obsolete, but please do it > > knowingly. > > Again, forgot something before sending: > > The idea was to be able to output other kinds of graph representation. > The current one is a very clumsy attempt at ASCII-art. But we could have > added: > > avfilter_graph_dump(graph, "fmt=dot"); > > to get output in Graphviz DOT format, basically importing > tools/graph2dot.c into libavfilter/graphdump.c. Finally doing that may > be a better idea than obsoleting the option.
Thanks for sharing the background, now the document isn't very clear how to use the option, after checking, nobody use it, so I think it's better to claim it as bool. I can take a look how to convert graph to dot format if nobody will support it. > > And of course, other formats are possible too. > > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
