NAK please remove this code fully.
On 5/10/20, Michael Niedermayer <mich...@niedermayer.cc> wrote: > Fixes: signed integer overflow: -234 * -14797801 cannot be represented in > type 'int' > Fixes: > 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5695924975435776 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > libavcodec/sonic.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c > index b82c44344c..ea6ef10c9e 100644 > --- a/libavcodec/sonic.c > +++ b/libavcodec/sonic.c > @@ -458,8 +458,8 @@ static void predictor_init_state(int *k, int *state, int > order) > > for (j = 0, p = i+1; p < order; j++,p++) > { > - int tmp = x + shift_down(k[j] * state[p], LATTICE_SHIFT); > - state[p] += shift_down(k[j]*x, LATTICE_SHIFT); > + int tmp = x + shift_down(k[j] * (unsigned)state[p], > LATTICE_SHIFT); > + state[p] += shift_down(k[j]* (unsigned)x, LATTICE_SHIFT); > x = tmp; > } > } > @@ -467,7 +467,7 @@ static void predictor_init_state(int *k, int *state, int > order) > > static int predictor_calc_error(int *k, int *state, int order, int error) > { > - int i, x = error - shift_down(k[order-1] * state[order-1], > LATTICE_SHIFT); > + int i, x = error - shift_down(k[order-1] * (unsigned)state[order-1], > LATTICE_SHIFT); > > #if 1 > int *k_ptr = &(k[order-2]), > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
