On 2020-05-02 15:35, Jai Luthra wrote:
Enables writing buffered frames to the outsink using send command api.
This is useful when a lavf user wants to fetch buffered frames without
closing/reopening the filtergraph again and again.
Signed-off-by: Jai Luthra <m...@jailuthra.in>
---
libavfilter/vf_fps.c | 36 +++++++++++++++++++++++++++---------
1 file changed, 27 insertions(+), 9 deletions(-)
…[snip]…
Jai:
I'm not an official reviewer or anything, but I have looked at the
libavfilter/vf_fps.c code recently.
This looks like a useful extension. I can imagine it being useful to
flush frames through the *fps* filter while FFmpeg is running. I could
imagine this patch pointing the way for further improvements later.
However, I don't see any change to the *fps* filter documentation in
this patch. If a patch changes the way a user can control a filter, but
doesn't document that change, then doesn't the patch cause the code to
diverge further from the documentation? And long-term, doesn't that lead
to problems?
Best regards,
—Jim DeLaHunt, software engineer, Vancouver, Canada
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
