On Sun, May 03, 2020 at 03:35:19PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > On Mon, Mar 30, 2020 at 06:52:32PM +0800, lance.lmw...@gmail.com wrote: > >> From: Limin Wang <lance.lmw...@gmail.com> > >> > >> Signed-off-by: Limin Wang <lance.lmw...@gmail.com> > >> --- > >> libavfilter/vf_subtitles.c | 6 ++---- > >> 1 file changed, 2 insertions(+), 4 deletions(-) > >> > >> diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c > >> index a3b4029af4..2f312b0ba8 100644 > >> --- a/libavfilter/vf_subtitles.c > >> +++ b/libavfilter/vf_subtitles.c > >> @@ -30,10 +30,8 @@ > >> #include <ass/ass.h> > >> > >> #include "config.h" > >> -#if CONFIG_SUBTITLES_FILTER > >> -# include "libavcodec/avcodec.h" > >> -# include "libavformat/avformat.h" > >> -#endif > >> +#include "libavcodec/avcodec.h" > >> +#include "libavformat/avformat.h" > >> #include "libavutil/avstring.h" > >> #include "libavutil/imgutils.h" > >> #include "libavutil/opt.h" > >> -- > >> 2.21.0 > >> > > > > ping > > > Why is this supposed to be unneeded? This file contains two filters: The > subtitles and the ass filter, so it is possible for this file to be > compiled if the subtitles filter is disabled.
Oh, yes, ass don't need include the header, I haven't tested such condition. please ignore the patch. > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
