On Sun, Mar 01, 2015 at 06:33:10PM -0800, Mark Reid wrote:
> hi,
> I was unsure whether this should be a function or a macro, I went with a 
> function.

i think functions are better, especially when you try to read a
backtrace in gdb
then again i think macros are better when you wonder why gcc didnt
inline that speed critical and trivial fuction and made the whole
software run half speed

I think the first case applies more often though


> 
> ---
>  libavformat/mxfdec.c | 61 
> +++++++++++++++++++---------------------------------
>  1 file changed, 22 insertions(+), 39 deletions(-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to