Am 23.02.15 um 19:46 schrieb Carl Eugen Hoyos: > Thilo Borgmann <thilo.borgmann <at> mail.de> writes: > >> For the second, what is that patch needed for? > > It is meant to fix warnings when compiling avfoundation > for ios, see for example: > http://fate.ffmpeg.org/log.cgi?time=20150223010210&log=compile&slot=aarch64-bo
You just misread me, I know what the first patch is for - which is what you just wrote. However, my question was about reason for the second "#define" patch. >> Is the existing check for MAC_OS_VERSION insufficient > > I would say it is neither sufficient nor insufficient, > MAX_OS_VERSION is not defined for ios. > >> it implicitly avoids IOS_VERSIONs thus any iPhone >> anyway, not? > > No? Thus, if "MAC_OS_VERSION" is undefined on iOS, the check will always be false and therefore we should not need another test about "!iOS". Correct -> I don't understand the second patch (apply if necessary). Incorrect -> Please apply the second patch. -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
