On Mon, Feb 23, 2015 at 01:59:45PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote:
> > Hi!
> > 
> > Attached patch fixes a crash with the following command line:
> > $ ffmpeg -loop 1 -i fate-suite/lena.pnm -vf format=yuva420p,fade -f null -
> > 
> > Please comment, Carl Eugen
> 
> >  vf_fade.c |    5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 31297e0aecbb7ec4637c180ae16254499c628334  patchfade.diff
> > diff --git a/libavfilter/vf_fade.c b/libavfilter/vf_fade.c
> > index 80ce75d..5d012af 100644
> > --- a/libavfilter/vf_fade.c
> > +++ b/libavfilter/vf_fade.c
> > @@ -203,7 +203,10 @@ static int filter_slice_luma(AVFilterContext *ctx, 
> > void *arg, int jobnr,
> >  
> >      for (i = slice_start; i < slice_end; i++) {
> >          uint8_t *p = frame->data[0] + i * frame->linesize[0];
> > +        int width = av_pix_fmt_desc_get(frame->format)->flags & 
> > AV_PIX_FMT_FLAG_PLANAR ?
> > +                    frame->width :
> > +                    frame->width * s->bpp;
> > -        for (j = 0; j < frame->width * s->bpp; j++) {
> > +        for (j = 0; j < width; j++) {
> 
> should be ok, alternatively bpp could be renamed and set to 1 for
> planar
> 

And moved out of the loop

[...]

-- 
Clément B.

Attachment: pgp_zw4NCVA8p.pgp
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to