On Sat, 14 Feb 2015, Clément Bœsch wrote:
On Sat, Feb 14, 2015 at 02:08:15AM +0100, Marton Balint wrote:
Signed-off-by: Marton Balint <c...@passwd.hu>
---
Makefile | 1 +
doc/ffplay.texi | 4 +
ffplay.c | 336 +++++--------------------------------
libavfilter/Makefile | 1 +
libavfilter/vf_ffplay_subtitle.c | 347 +++++++++++++++++++++++++++++++++++++++
libavfilter/vf_ffplay_subtitle.h | 38 +++++
6 files changed, 434 insertions(+), 293 deletions(-)
create mode 100644 libavfilter/vf_ffplay_subtitle.c
create mode 100644 libavfilter/vf_ffplay_subtitle.h
This is not the correct way of doing it.
The proper way is to integrate subtitles within lavfi. If you want to work
toward this, feel free to ask for more details, but it's not trivial.
(and no, this patch is not an improvement in the correct direction, sorry)
What would be an improvement in the right direction? I see little chance
that I will work on subtitles in lavfi, but if there is a better/preferred
way to change ffplay to support subtitles in the filter chain without
waiting for the whole subtitles-in-libavfilter infrastructure, I may be
interested in working toward that.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
