On Mon, 9 Feb 2015 23:49:00 +0100 Michael Niedermayer <michae...@gmx.at> wrote:
> On Mon, Feb 09, 2015 at 10:33:53PM +0100, wm4 wrote: > > Otherwise, you could lose the alpha when handling pixel formats in an > > opaque manner (i.e. when you don't special-case PAL8). > > > > The special case for av_get_pix_fmt_loss()/av_find_best_pix_fmt_of_2() > > is now redundant and can be removed. > > --- > > Fate still passes. > > fate fails here > make V=2 fate-ac3-2.0 > TEST ac3-2.0 > [...] > Assertion (d->nb_components==4 || d->nb_components==2) == !!(d->flags & (1 << > 7)) failed at libavutil/pixdesc.c:2097 > Aborted (core dumped) > make: *** [fate-ac3-2.0] Error 134 > > [...] It doesn't fail here, even with the same command. Anyway, patch dropped, too many problems and inconsistencies. (There's probably a lot of code that checks for the number of components explicitly. Although the AVPixFmtDescriptor.comp doxygen is completely inconsistent with PAL8. Well, whatever.) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
