On Sun, Jan 11, 2015 at 05:14:44PM -0800, Mark Reid wrote: > On Fri, Jan 9, 2015 at 7:47 PM, Michael Niedermayer <michae...@gmx.at> > wrote: > > > On Mon, Jan 05, 2015 at 04:53:05PM -0800, Mark Reid wrote: > > > Hi, > > > MXF files generated by Media Composer or LibMXF can contain a > > > project name property in the Preface. Lots of existing samples have them. > > > > > > http://samples.ffmpeg.org/MXF/issue2160/PW0805A0V01.4C5B5636.EFA330.mxf > > > project_name : DNX145 PW Test > > > > > > > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3450/WriteAvidMXFgenerated/5502_0010_v1.mxf > > > project_name : Rombus > > > > > > > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3100/1sec_mxf_test_Video5270C795.mxf > > > project_name : NVB_DOOD > > > > > > i can also provide more samples if needed. > > > > > > --- > > > libavformat/mxfdec.c | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > should i apply this patch? > > or is there some reason remaining not to ? > > the thread was kind of not ending with any clear conclusion and noone > > applied it ... > > > > [...] > > -- > > > > I assume everything was alright, only didn't get a sign off. The only > feedback I got, so far, was perhaps changing the metadata key to "title", > instead of "project_name", but we both agreed that the data is not the > title.
patch applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
