On Tue, Dec 30, 2014 at 08:33:49PM +0100, Michael Niedermayer wrote: > On Tue, Dec 30, 2014 at 06:25:26PM +0100, Clément Bœsch wrote: > > From: Clément Bœsch <clem...@stupeflix.com> > > > > --- > > Another approach this time: exporting a filtergraph from the demuxer > > (when requested) and inserting it in the tools automatically. > > > > FIXME: doesn't work when using -ss with ffmpeg, maybe because it's > > shifting the timestamps of the frames before feeding them to > > libavfilter. I probably need guidance here. > > > > TODO: add -honor_timeline bool option in ffmpeg > > --- > > ffmpeg_filter.c | 29 +++++++++++++++++++++ > > ffmpeg_opt.c | 8 +++++- > > ffplay.c | 46 ++++++++++++++++++++++++++++++++- > > libavformat/mov.c | 76 > > +++++++++++++++++++++++++++++++++++++++++++++++++++++-- > > 4 files changed, 155 insertions(+), 4 deletions(-) > > the patchset breaks 3 fate tests > make: *** [fate-h264-interlace-crop] Error 1 > make: *** [fate-quickdraw] Error 1 > make: *** [fate-gsm-toast] Error 1 >
Right, that's because these samples have edit lists, and they are now honored, somehow. There are now at least 4 things to fix AFAICT: - when the lavfi timeline is enabled, the start time in the presentation might not be supported properly - AFAIK aselect is not sample accurate, but frame accurate, so it doesn't cut that accurately - the current patch is broken with ffmpeg -ss (and probably other similar options) - in ffmpeg, the timeline option must not be enabled in case of stream copy That said, I will probably push the first two patchs since they are harmless, unless someone objects. -- Clément B.
pgpXw3RUiIbOM.pgp
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
