On 15 December 2014 at 13:05, Nicolas George <geo...@nsup.org> wrote: > > Le quintidi 25 frimaire, an CCXXIII, Lukasz Marek a écrit : > > snd_pcm_close() doesn't handle NULL correctly. > > > > Signed-off-by: Lukasz Marek <lukasz.m.lu...@gmail.com> > > --- > > libavdevice/alsa-audio-common.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > I think it is ok, but can you explain the code path that leads to it? >
for example ffmpeg -f alsa -i aaaa -f alsa aaa would crash if ffmpeg tried to close alsa after open fail. It doesn't so it doesn't occur. This commit also make safe to call close function twice on the same context _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel