Re: [FFmpeg-devel] [PATCH] configure: do not allow nvenc to be build on cygwin to avoid _WIN32 definition hack

[Michael Niedermayer]

On Thu, Dec 11, 2014 at 12:02:15AM -0300, James Almer wrote:
> On 10/12/14 11:47 PM, Michael Niedermayer wrote:
> > Suggested-by: jamrial
> > Signed-off-by: Michael Niedermayer <michae...@gmx.at>
> > ---
> >  configure |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index e6257ca..9d04ee2 100755
> > --- a/configure
> > +++ b/configure
> > @@ -4934,7 +4934,8 @@ enabled libxavs           && require libxavs xavs.h 
> > xavs_encoder_encode -lxavs
> >  enabled libxvid           && require libxvid xvid.h xvid_global -lxvidcore
> >  enabled libzmq            && require_pkg_config libzmq zmq.h zmq_ctx_new
> >  enabled libzvbi           && require libzvbi libzvbi.h vbi_decoder_new 
> > -lzvbi
> > -enabled nvenc             && { check_header nvEncodeAPI.h || die "ERROR: 
> > nvEncodeAPI.h not found."; }
> > +enabled nvenc             && { check_header nvEncodeAPI.h || die "ERROR: 
> > nvEncodeAPI.h not found."; } &&
> > +                             { [ $target_os != cygwin ] || die "ERROR: 
> > NVENC is not supported on Cygwin currently."; }
> >  enabled openal            && { { for al_libs in "${OPENAL_LIBS}" 
> > "-lopenal" "-lOpenAL32"; do
> >                                 check_lib 'AL/al.h' alGetError "${al_libs}" 
> > && break; done } ||
> >                                 die "ERROR: openal not found"; } &&
> > 
> 
> LGTM

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.

signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel